Skip to content

Adopt TerminalVirtualProcess for Custom task execution #76852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2019
Merged

Adopt TerminalVirtualProcess for Custom task execution #76852

merged 3 commits into from
Jul 10, 2019

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Jul 8, 2019 •
edited
Loading

Fixes #76492

@alexr00 alexr00 added this to the July 2019 milestone Jul 8, 2019
@alexr00 alexr00 self-assigned this Jul 8, 2019
alexr00 and others added 2 commits July 9, 2019 11:37
@alexr00
Update Custom task execution API to return TerminalVirtualProcess in …
83c08e4 
…callback

This also required the addtion of a start on the virtual terminal process
@Tyriar
Clarify start API
1dff4d4
Tyriar
Tyriar approved these changes Jul 9, 2019
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexr00 alexr00 merged commit e84fc70 into master Jul 10, 2019
@alexr00 alexr00 deleted the alexr00/customTaskVirtualProc branch July 10, 2019 07:31
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@alexr00 alexr00

Labels
None yet
Projects
None yet
Milestone
July 2019
Development

Successfully merging this pull request may close these issues.

Adopt virtual process terminals in task custom execution API
2 participants
@alexr00 @Tyriar