Telemetry Command #76029

lramos15 · 2019-06-24T16:38:13Z

Adds a --telemetry command to the VS Code CLI which dumps all the the telemetry events which VS Code collects.

sbatten · 2019-06-24T22:08:27Z

@joaomoreno please review the build pipeline changes.

build/azure-pipelines/linux/product-build-linux-alpine.yml

src/vs/platform/environment/node/argv.ts

Tyriar

Can you reduce duplication by deferring to script(s) in ./build/azure-pipelines?

Tyriar

LGTM, feel free to defer the code duplication if you're sure it's good.

lramos15 · 2019-06-25T01:05:19Z

Deferring to scripts is good but I won't have adequate testing in time for it to get into the June milestone, so I will look into it for the July one as I know this works and don't want to break anything

joaomoreno · 2019-06-25T09:18:52Z

@lramos15 @Tyriar @sbatten I have a few questions:

Why does this need to be run per platform? This is important given that we want to reduce the amount of platform-specific work for improving the build perf: Improve build perf #75983.
If this works by parsing GDPR formatted contents, why do we need to run Code at all to spit out information? Why isn't this just done statically against our sources?
If code --telemetry spits out all the information, what's the purpose of https://github.com/microsoft/vscode-telemetry-extractor?
Why are we cloning https://github.com/microsoft/vscode-telemetry-extractor instead of publishing that as a package to npm and using a specific version of that in our devDependencies? We want to always have reproducible builds... and currently builds will always get master from that repo, voiding this contract.

joaomoreno · 2019-06-25T09:19:21Z

build/azure-pipelines/darwin/product-build-darwin.yml

+    node ./out/cli-extract-extensions.js --sourceDir ./src/telemetry-sources/ --outputDir . --applyEndpoints --includeIsMeasurement
+    mv declarations-resolved.json ../s/src/telemetry-core.json
+    mv declarations-extensions-resolved.json ../s/src/telemetry-extensions.json
+    echo 'Moved Files'


This should just be removed.

So Darwin doesn't need a specific build script?

I mean the echo. 👍

joaomoreno · 2019-06-25T09:20:07Z

src/vs/platform/environment/node/argv.ts

+		mergeTelemetry(contents, 'vscode-extensions');
+		return JSON.stringify(mergedTelemetry, null, 4);
+	} catch (err) {
+		return 'Unable to read VS Code telemetry events!';


Just remove the whole try catch block and let the actual error bubble up and be printed to the console.

src/vs/platform/environment/node/argv.ts

build/azure-pipelines/linux/product-build-linux.yml

joaomoreno · 2019-06-25T10:20:05Z

I've talked to @kieferrm about this and he helped me understand this better. Answering my own questions:

This is not platform specific. If we go along with Improve build perf #75983 this won't be a problem.
I got the flow wrong. This is statically computed. Code spitting out telemetry IS the feature this PR implements.
Understood.

I'd still highly recommend publishing https://github.com/microsoft/vscode-telemetry-extractor to NPM and locking it in our yarn.lock file.

lramos15 · 2019-06-25T14:59:29Z

Yeah sorry for not explaining it well. Ideally we would only compute this once and copy it somehow to all the platforms, but since each platform is run in parallel I wasn't sure how to accomplish that. You are correct that it should be an NPM package, but the telemetry extractor is not open source yet so the plan was to hold off on releasing an NPM package until the tool was open sourced.

joaomoreno · 2019-06-25T15:08:26Z

You are correct that it should be an NPM package, but the telemetry extractor is not open source yet so the plan was to hold off on releasing an NPM package until the tool was open sourced.

Then let's lock the clone to a specific commit ID for now.

sbatten · 2019-07-02T17:29:26Z

src/vs/platform/environment/common/environment.ts

@@ -13,6 +13,7 @@ export interface ParsedArgs {
 	_urls?: string[];
 	help?: boolean;
 	version?: boolean;
+	telemetry?: boolean;


@lramos15 shouldn't break anything but missed this arg when removing the command

sbatten · 2019-07-02T17:31:15Z

build/gulpfile.vscode.js

@@ -62,6 +62,8 @@ const vscodeResources = [
 	'out-build/bootstrap-amd.js',
 	'out-build/bootstrap-window.js',
 	'out-build/paths.js',
+	'out-build/telemetry-core.json',
+	'out-build/telemetry-extensions.json',


@lramos15 I noticed this code isn't in master anymore but it wasn't removed during the PR to remove the command. What happened to it?

lramos15 added 4 commits June 19, 2019 15:35

Added telemetry command

5424aa3

Initial Build support

1d1d0f1

Added build logic for telemetry

947ff83

Merge remote-tracking branch 'microsoft/master' into telemetry-command

831a547

lramos15 requested a review from sbatten June 24, 2019 16:38

lramos15 self-assigned this Jun 24, 2019

lramos15 added 4 commits June 24, 2019 09:43

Linux Builds

f25400c

Windows builds sort of work

d5598a9

Remove arm telemetry extraction

9d2e9d6

Remove alpine telemetry extraction

136e1bb

sbatten requested a review from joaomoreno June 24, 2019 22:08

Remove accidental s

c1159dc

sbatten requested changes Jun 24, 2019

View reviewed changes

More try catch

976e227

sbatten self-requested a review June 24, 2019 23:05

sbatten approved these changes Jun 24, 2019

View reviewed changes

Tyriar reviewed Jun 24, 2019

View reviewed changes

Tyriar approved these changes Jun 24, 2019

View reviewed changes

This was referenced Jun 25, 2019

Test for the telemetry command #76056

Closed

Test Telemetry Command's extension suppot #76057

Closed

lramos15 merged commit 4a69a71 into microsoft:master Jun 25, 2019

Tyriar mentioned this pull request Jun 25, 2019

Move extract telemetry script in pipelines to a helper script #76058

Closed

joaomoreno reviewed Jun 25, 2019

View reviewed changes

src/vs/platform/environment/node/argv.ts Show resolved Hide resolved

build/azure-pipelines/linux/product-build-linux.yml Show resolved Hide resolved

This was referenced Jun 25, 2019

Improve Telemetry Command Build Process #76113

Closed

Improvements to Telemetry Extractor Build #76196

Merged

joaomoreno added this to the June 2019 milestone Jun 27, 2019

joaomoreno added vscode-build VS Code build process issues engineering VS Code - Build / issue tracking / etc. labels Jun 27, 2019

sbatten reviewed Jul 2, 2019

View reviewed changes

github-actions bot locked and limited conversation to collaborators Mar 27, 2020

Telemetry Command #76029

Telemetry Command #76029

Uh oh!

Conversation

lramos15 commented Jun 24, 2019

Uh oh!

sbatten commented Jun 24, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Tyriar left a comment

Choose a reason for hiding this comment

Uh oh!

Tyriar left a comment

Choose a reason for hiding this comment

Uh oh!

lramos15 commented Jun 25, 2019

Uh oh!

joaomoreno commented Jun 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joaomoreno Jun 25, 2019

Choose a reason for hiding this comment

Uh oh!

lramos15 Jun 25, 2019

Choose a reason for hiding this comment

Uh oh!

joaomoreno Jun 26, 2019

Choose a reason for hiding this comment

Uh oh!

joaomoreno Jun 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

joaomoreno commented Jun 25, 2019

Uh oh!

lramos15 commented Jun 25, 2019

Uh oh!

joaomoreno commented Jun 25, 2019

Uh oh!

sbatten Jul 2, 2019

Choose a reason for hiding this comment

Uh oh!

sbatten Jul 2, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

joaomoreno commented Jun 25, 2019 •

edited

Loading

joaomoreno Jun 25, 2019 •

edited

Loading