Skip to content

Fix possible crash in winpty #74685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 31, 2019
Merged

Fix possible crash in winpty #74685

merged 2 commits into from
May 31, 2019

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented May 31, 2019

Fixes #74181

@Tyriar Tyriar added this to the May 2019 milestone May 31, 2019
@Tyriar Tyriar requested a review from rebornix May 31, 2019 17:02
@Tyriar Tyriar mentioned this pull request May 31, 2019
Closed
@Tyriar
Actually fix the issue
bd08ccf 
typeof NaN is number :/
rebornix
rebornix approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Tyriar Tyriar merged commit 7553a90 into master May 31, 2019
@Tyriar Tyriar deleted the tyriar/74181 branch May 31, 2019 17:30
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rebornix rebornix rebornix approved these changes

Assignees

@rebornix rebornix

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
May 2019
Development

Successfully merging this pull request may close these issues.

Crashes when quickly press ctrl+` twice
2 participants
@Tyriar @rebornix