return of the dynamic menu #59855
Merged
return of the dynamic menu #59855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpasero
approved these changes
Oct 3, 2018
There was a problem hiding this comment.
This seems to work nicely.
In the spirit of keeping the data in the state service to a minimum, can we maybe try to produce less verbose data? All of this goes into one file (/Users/<name>/Library/Application Support/code-oss-dev/storage.json) that is saved on each change, so I would like to avoid producing too much data. Some things that would help:
- remove the now obsolete
lastKnownKeybindingsafter we have made the transition fully - all menu items seem to be
enabled, so remove this property - remove the redundant
keybindingfrom menu items, that data seems to be duplicate for thelastKnownAdditionalKeybindingsthat we also store
|
@bpasero creating a separate issue to reduce menu cache verbosity |
This was referenced Oct 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bring back dynamic menubar for macOS and use a caching mechanism
resolves #58928