Prev/Next Panel/Sidebar view. Part of #44625 #59270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assigning to October to review then |
|
@octref great work! I like the changes and I like how this behaves. I was not sure about naming, but after second thought the current naming works for me. @octref as for your feedback regarding viewlet.ts feel free to open more prs with proposed changes so we discuss them and potentially merge. Thanks a lot! |
isidorn
approved these changes
Oct 2, 2018
|
Since @sandy081 is not replying I will just merge this in. |
|
Sorry I was on vacation. LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #44796.
@sandy081 @isidorn I think some methods in the Panel/Sidebar parts are confusing, for example:
From Panel perspective,
Searchisvisiblewhensearch.locationis set topanel. However, you can unpin the search panel through context menu like so:In this case, even though
Searchpanel is hidden (through unpinning), it is stillvisible.In
viewlet.ts,getViewletsandgetAllViewletsshould be better named to reflect what they do