Support multiple configurations in extension editor #54116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
sandy081
requested changes
Jul 12, 2018
| @@ -594,7 +594,13 @@ export class ExtensionEditor extends BaseEditor { | |||
| private renderSettings(container: HTMLElement, manifest: IExtensionManifest, onDetailsToggle: Function): boolean { | |||
| const contributes = manifest.contributes; | |||
| const configuration = contributes && contributes.configuration; | |||
| const properties = configuration && configuration.properties; | |||
| let properties = configuration && configuration.properties; | |||
There was a problem hiding this comment.
May be we should fix the type of contribues.configuration to be IConfiguration | IConfiguration[] and the consumers can check for the type?
There was a problem hiding this comment.
Updated the type.
|
LGTM |
sandy081
approved these changes
Jul 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #54098
The CSS Language Features extensions fails to show any settings in the "Contributions" section of the extensions editor. This is because it contributes to multiple configuration targets and the editor cannot support this case