Skip to content

Remove PPromise usage from task world #53875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2018
Merged

Remove PPromise usage from task world #53875

merged 1 commit into from
Jul 11, 2018

Conversation

joaomoreno
Copy link
Member

@joaomoreno joaomoreno commented Jul 9, 2018 •
edited
Loading

@dbaeumer This was actually pretty easy.

Related to #53487, #53526

@joaomoreno joaomoreno added debt Code quality issues engineering VS Code - Build / issue tracking / etc. labels Jul 9, 2018
@joaomoreno joaomoreno added this to the July 2018 milestone Jul 9, 2018
@joaomoreno joaomoreno self-assigned this Jul 9, 2018
@joaomoreno joaomoreno requested a review from dbaeumer July 9, 2018 14:23
@joaomoreno joaomoreno changed the title Remove ppromise usage from task world Remove PPromise usage from task world Jul 9, 2018
@joaomoreno joaomoreno mentioned this pull request Jul 9, 2018
Merged
11 tasks
@dbaeumer
Copy link
Member

LGTM. Feel free to merge in at our convenience.

And thanks for doing this.

dbaeumer
dbaeumer approved these changes Jul 10, 2018
View reviewed changes
Copy link
Member

@dbaeumer dbaeumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaomoreno joaomoreno merged commit cf7e152 into master Jul 11, 2018
@joaomoreno joaomoreno deleted the joao/remove-ppromise-tasks branch July 11, 2018 09:06
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbaeumer dbaeumer dbaeumer approved these changes

Assignees

@joaomoreno joaomoreno

Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Milestone
July 2018
Development

Successfully merging this pull request may close these issues.
2 participants
@joaomoreno @dbaeumer