Remove ppromise usage from chokidar #53584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
czw., 5.07.2018, 13:05 użytkownik João Moreno <notifications@github.com>
napisał:
… Similar to #53556 <#53556>
Did the setTimeout trick for the ENOSPC error as well here.
------------------------------
You can view, comment on, or merge this pull request online at:
#53584
Commit Summary
- remove ppromise usage from chokidar
File Changes
- *M*
src/vs/workbench/services/files/node/watcher/unix/chokidarWatcherService.ts
<https://github.com/Microsoft/vscode/pull/53584/files#diff-0> (27)
- *M*
src/vs/workbench/services/files/node/watcher/unix/test/chockidarWatcherService.test.ts
<https://github.com/Microsoft/vscode/pull/53584/files#diff-1> (20)
- *M* src/vs/workbench/services/files/node/watcher/unix/watcher.ts
<https://github.com/Microsoft/vscode/pull/53584/files#diff-2> (10)
- *M* src/vs/workbench/services/files/node/watcher/unix/watcherIpc.ts
<https://github.com/Microsoft/vscode/pull/53584/files#diff-3> (19)
- *M*
src/vs/workbench/services/files/node/watcher/unix/watcherService.ts
<https://github.com/Microsoft/vscode/pull/53584/files#diff-4> (48)
Patch Links:
- https://github.com/Microsoft/vscode/pull/53584.patch
- https://github.com/Microsoft/vscode/pull/53584.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#53584>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/Almcl0cUghk1aFypNAVWMqSufWYbVWJfks5uDfLggaJpZM4VDrv_>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #53556
Did the setTimeout trick for the
ENOSPCerror as well here.