Build with TS 2.7 #45348
Merged
Build with TS 2.7 #45348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Mar 8, 2018
yarn.lock
Outdated
| typescript@2.6.1: | ||
| version "2.6.1" | ||
| resolved "https://registry.yarnpkg.com/typescript/-/typescript-2.6.1.tgz#ef39cdea27abac0b500242d6726ab90e0c846631" | ||
| typescript@2.7.1: |
There was a problem hiding this comment.
Why was this changed in yarn.lock but typescript-formatter wasn't? It's still at 4.0.1 just above this.
There was a problem hiding this comment.
Running yarn on my checkout of this branch causes many yarn.lock changes including typescript-formatter.
There was a problem hiding this comment.
Bad rebase. The error is from TS 2.7.2 with ts-formatter 7.1.0 though
|
Updating yarn versions fixed the tslint error. Just a few formatting errors now. Thanks for the suggestion @Andy-MS! |
joaomoreno
pushed a commit
that referenced
this pull request
Mar 9, 2018
* Pick up TS 2.7 * Fix formatter in build script * Fix build error for ts 2.7 * Pick up new ts format and tslint versions * Update lock * use 2.7.2 for build * Formatting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42853