Theme Changes to better align with Visual Studio Light and Dark themes #92965
Description
I recently experimented with adding a semantic token provider to the C# extension (dotnet/vscode-csharp#3667). This made apparent that the VS Code Light+ and Dark+ themes need to be updated so that the out of the box experience with semantic classification closely aligns with the default Visual Studio Light and Dark themes.
These are the changes I made to get an experience that was consistent with the Visual Studio default themes:
"editor.tokenColorCustomizations": {
"[Default Dark+]": {
"textMateRules": [
{
"scope": "entity.name.namespace",
"settings": {
"foreground": "#D4D4D4"
}
},
{
"scope": "entity.name.variable.field",
"settings": {
"foreground": "#D4D4D4"
}
},
{
"scope": "variable.other.property",
"settings": {
"foreground": "#D4D4D4"
}
},
{
"scope": "variable.other.constant",
"settings": {
"foreground": "#D4D4D4",
}
},
{
"scope": "variable.other.enummember",
"settings": {
"foreground": "#D4D4D4"
}
},
{
"scope": "entity.name.type.interface",
"settings": {
"foreground": "#b8d7a3"
}
},
{
"scope": "entity.name.type.enum",
"settings": {
"foreground": "#b8d7a3"
}
},
{
"scope": "entity.name.type.parameter",
"settings": {
"foreground": "#b8d7a3"
}
},
{
"scope": "storage.type.struct",
"settings": {
"foreground": "#86C691",
}
},
{
"scope": "entity.name.function.extension",
"settings": {
"foreground": "#DCDCAA",
}
}
]
},
"[Default Light+]": {
"textMateRules": [
{
"scope": "entity.name.namespace",
"settings": {
"foreground": "#222222"
}
},
{
"scope": "entity.name.variable.field",
"settings": {
"foreground": "#222222"
}
},
{
"scope": "variable.other.property",
"settings": {
"foreground": "#222222"
}
},
{
"scope": "variable.other.constant",
"settings": {
"foreground": "#222222",
}
},
{
"scope": "variable.other.enummember",
"settings": {
"foreground": "#222222"
}
},
{
"scope": "entity.name.type.interface",
"settings": {
"foreground": "#267f99"
}
},
{
"scope": "entity.name.type.enum",
"settings": {
"foreground": "#267f99"
}
},
{
"scope": "entity.name.type.parameter",
"settings": {
"foreground": "#267f99"
}
},
{
"scope": "storage.type.struct",
"settings": {
"foreground": "#267f99",
}
},
{
"scope": "entity.name.function.extension",
"settings": {
"foreground": "#795E26",
}
}
]
}
},With Textmate Classification:
With Semantic Classification:
With Semantic Classification and Visual Studio 2019 theme tweaks: