With the introduction of View Menu Actions its possible for ViewPanes to accidentally override them. We should verify if this is happening and consider if we still want View Menu Actions with DnD for views already introduced.
/cc @eamodio

Updated Description

Currently ViewPanes and ViewPaneContainers can contribute Primary, Secondary and ContextMenu actions in following ways

• Primary actions

  • Provide using getActions
  • Register to ViewContainerTitle menu with navigation group
  • Register to ViewTitle menu with navigation group

• Secondary actions

  • Provide using getSecondaryActions
  • Register to ViewContainerTitle menu
  • Register to ViewTitle menu

• Context menu actions

  • Provide using getContextMenuActions
  • Register to ViewContainerTitleContext menu
  • Register to ViewTitleContext menu

We would like to move away from get*Actions and use Menu registry because

• All actions shall be command driven so that user can assign keybindings
• Facilitates providing customizable menus
• Improves code quality
  • One consistent way to register actions across workbench
  • Allows removing redundant code if the same action is used at multiple places
  • Helps in removing ambiguity of actions lifecycle and simplifies views as they do not need to maintain actions state

I will be removing the get*Actions method after everyone move away from it. I listed the existing consumers of this and assigned the respective owner. Please adopt using Menu registries.

Here are some tips that might help you while adopting

• If you have a custom UI for your action, you can override getActionViewItem like before and provide custom implementation.

Example:

• If your action needs access to your view's or view container's state, you can use ViewAction or ViewPaneContainerAction. They will pass our view or viewPaneContainer as arg in run method

Example:

To Adopt

• Search - @roblourens

  • vscode/src/vs/workbench/contrib/search/browser/searchView.ts

    Line 1849 in 2ecb47d

    getActions(): IAction[] {

• Terminal - @Tyriar @meganrogge

  • vscode/src/vs/workbench/contrib/terminal/browser/terminalView.ts

    Line 157 in 0ef0d2d

    public getActions(): IAction[] {