-
Notifications
You must be signed in to change notification settings - Fork 34.9k
Closed
Labels
feature-requestRequest for new features or functionalityRequest for new features or functionality
Milestone
Description
Follow up of #88243, and the work is now happening in #86632 . We will build a solid implementation of Notebook Editor in the core this iteration based on the feature list we curated.
We will focus on the rendering of inputs/outputs and basic cell manipulation commands first and then explore how to support editor features in native notebook editor. At the same time we should move off workarounds in the prototype to ensure the PR in a mergeable state.
- Rendering
- Outputs Mimetypes
- 🏃 LaTeX (see details Notebook implementation in core (rendering / editor features) #90382 (comment)).
- application/json.
- image/*. We render PNG and JEPG in core but svg and gifs should be rendered in webview/iframe. (GIF support is a must as we don't support videos).
- application/scripts.
- Metadata
- Cell metadata which controls the renderings of cells, like editable, execution_count
- Output metadata, like whether the output should be rendered in an isolated context.
- Outputs Mimetypes
- Cell Manipulation
- run cell, select below
- run cell and insert below
- insert cell above
- insert cell below
- cut selected cells
- copy selected cells
- paste
- Editor features
- Save/SaveAs/AutoSave
- Hot Exit
- View States preserve and restore
- Cursor movement across cells
- Engineering
- List View
- Dynamic height update
-
isRendering
state - Optional List Item Height style
- Willscroll event
- Backing layer
- Webview
-
body
height/width100%
-
wheel
event handler -
Event for initial layout (for dimensions info)
-
- CodeEditorWidget
- Remove DOM safely
- List View
Metadata
Metadata
Assignees
Labels
feature-requestRequest for new features or functionalityRequest for new features or functionality