-
Notifications
You must be signed in to change notification settings - Fork 34.4k
Description
Per previous explorations, there are two changes we would like to make for profiling in VS Code. I've presented these as independent features, however we could also take the approach of supporting a generalized "profiling" state through DAP and drive the UI from that.
[ ] 1. The ability to contribute a hover action to targets in the call stack view.
This serves as a point of discovery for profiling. An additional contribution point like debug/callstack/actions
would be the most straightforward approach for this.
[ ] 2. The ability to set a custom sub-state for debug sessions
This could be a VS Code-specific API like how we can change the DebugSession.name
today, which would feel natural to me. Alternatively, it could be a new method on DAP. @weinand interested to hear your thoughts, I will open a proposal on the DAP repo if we want to go that route.
[x] 3. Disabling pausing the profile is running
For discussion: this is in the mockups and something I mentioned wanting before, but thinking on it further I would rather enable it and simply prompt the user when they click it with a modal like
Pausing your program will interrupt the profiling process. Do you want to stop profiling and pause now? [Always] [Yes] [[No]]
With this implementation we would not need UI changes.