Skip to content

Problems for Data Breakpoint #83649

@testforstephen

Description

@testforstephen
  • VSCode Version:
Version: 1.40.0-insider (system setup)
Commit: b7b21844e760e632f39bedf651da2bc93f54b0cc
Date: 2019-10-29T06:48:38.866Z
Electron: 6.1.2
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.18363
  • OS Version: Windows 10

I try to enable data breakpoint for Java debugger, here are some problems i find.

  • VS Code didn't respect the accessTypes attribute of DataBreakpointInfoResponse. When it returns an array ['read', 'write', 'readWrite'], right click the variable, the menu only showsBreak When Value Changes.
  • VS Code didn't respect the canPersist attribute of DataBreakpointInfoResponse well. When it is true, the BREAKPOINTS viewlet will keep it there after the debug session terminates. But when launching a new debug session, no setDataBreakpoints request are sent to debugger during initialization. The debugger has no chance to enable the persisted data breakpoints.
  • Cannot edit the attributes for the existed data breakpoint. For example, cannot change its access type, no UI to add condition and hitCondition.
  • Should distinct the data breakpoint for the same variable or type. Currently, i can add multiple duplicated Data Breakpoints for the same variable. It's better to disable this operation if there is a data breakpoint existed for the same variable. Maybe dataId can be used as the key to detect the duplication.
  • Add a simple way to enable data breakpoint. Currently, i must trigger a breakpoint first, then right click the target variable in the Variable view for that. In fact, Java debugger only supports enabling data breakpoint for the Field, so if the user can enable data breakpoint via clicking the Field declaration code line directly, feel like it's more convenient.

Metadata

Metadata

Labels

debugDebug viewlet, configurations, breakpoints, adapter issuesfeature-requestRequest for new features or functionality

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions