-
Notifications
You must be signed in to change notification settings - Fork 34.5k
Closed
Labels
electronIssues and items related to ElectronIssues and items related to Electronelectron-blockerIssues in next update of Electron preventing updateIssues in next update of Electron preventing updateupstreamIssue identified as 'upstream' component related (exists outside of VS Code)Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone
Description
Tracks the VS Code side of microsoft/TypeScript#33564
Repo
On MacOS with VS Code insiders
For the project:
tsconfig.js
{
"compilerOptions": {
"module": "commonjs",
"target": "es2016",
"jsx": "react"
}
}
src/main.ts
export function foo() {
add
}
- Open main.ts
- Create a new file
src/add.ts
in VS Code
export function add() { }
-
Back in
main.ts
, try auto importingadd
🐛 Doesn't show up
-
In
add
, run theTypeScript: Go to project configuration
command. This should open thetsconfig.json
🐛 File is not part of any project
Investigation
Something seems busted with using any version of TypeScript + Electron 6 on MacOS. I've tested the following cases so far:
- MacOS, newest TS with VS Code Stable — ✅ works
- MacOS, stable TS with VS Code Stable — ✅ works
- MacOS, stable TS with VS Code insides — ❌ broken
- MacOS, newest TS with VS Code insides — ❌ broken
- MacOS, TS 3.3 (an old version) with VS Code insiders — ❌ broken
- Windows, any TS with VS Code Insiders — ✅ works
Behind the scenes, TS uses node's fs.watch
by default so I suspect the bug is somewhere with that not firing events properly
As @RyanCavanaugh and @sheetalkamat brought up, we cannot fix this on the TS side old TS versions are also broken
Metadata
Metadata
Assignees
Labels
electronIssues and items related to ElectronIssues and items related to Electronelectron-blockerIssues in next update of Electron preventing updateIssues in next update of Electron preventing updateupstreamIssue identified as 'upstream' component related (exists outside of VS Code)Issue identified as 'upstream' component related (exists outside of VS Code)