-
Notifications
You must be signed in to change notification settings - Fork 34.5k
Closed
Labels
engineeringVS Code - Build / issue tracking / etc.VS Code - Build / issue tracking / etc.smoke-test-failurewebIssues related to running VSCode in the webIssues related to running VSCode in the web
Milestone
Description
All my recent changes to let the integration tests run against the real produced build have lead to the web smoke tests now failing because we are assuming compilation artifacts in ./out
while they are in ./out-build
on the server. The smoke tests were lucky because previously the integration tests would trigger a full compile.
Instead of fixing this the wrong way, I strongly suggest to change the web smoke tests to:
- run against the actual web client bits that are being produced
- using the actual server that is being produced
You can see how we figure out the location of both client and server:
For now I will disable the smoke tests until we have this resolved.
//cc @aeschli
Metadata
Metadata
Labels
engineeringVS Code - Build / issue tracking / etc.VS Code - Build / issue tracking / etc.smoke-test-failurewebIssues related to running VSCode in the webIssues related to running VSCode in the web