-
Notifications
You must be signed in to change notification settings - Fork 34.9k
Closed
Labels
debtCode quality issuesCode quality issuesupstreamIssue identified as 'upstream' component related (exists outside of VS Code)Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone
Description
When we minify, we have to pass in hoist_funs: true
, otherwise we get below results:
Somehow our json parser stumbles over our language configurations otherwise. I have not fully figured out why that is, but this is something we should follow up.
To reproduce:
- search for
hoist_funs: true
inbuild/lib/optimize.ts
and change it tofalse
yarn gulp vscode-darwin-min
- run the minified build
//cc @chrmarti
Metadata
Metadata
Assignees
Labels
debtCode quality issuesCode quality issuesupstreamIssue identified as 'upstream' component related (exists outside of VS Code)Issue identified as 'upstream' component related (exists outside of VS Code)