vscode.TerminalRenderer.onDidChangeMaximumDimension doesn't fire if renderer window height increases #73496
Description
Issue Type: Bug
details
VS Code version: Code 1.33.1 (51b0b28, 2019-04-11T08:27:09.080Z)
OS version: Windows_NT ia32 10.0.17763
System Info
| Item | Value |
|---|---|
| CPUs | Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 x 3408) |
| GPU Status | 2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: enabled surface_synchronization: enabled_on video_decode: enabled webgl: enabled webgl2: enabled |
| Memory (System) | 31.92GB (22.10GB free) |
| Process Argv | --folder-uri file:///c%3A/src/cascade/vscode/extension |
| Screen Reader | no |
| VM | 0% |
Repro steps:
- In VSCode extension, create a terminal render with
vscode.window.createTerminalRenderer(name); - Subscribe to
onDidChangeMaximumDimensionsevent on the renderer. - In the event handler, set
renderer.dimensionsto the new maximum dimensions after some time the event has fired (like in 100 ms). - Try to resize the terminal pane in VSCode UI.
Expected:
onDidChangeMaximumDimensions event fires whenever the terminal pane is resized, regardless of whether it is increasing its height, or decreasing.
Actual:
onDidChangeMaximumDimensions event fires only when the terminal pane height is decreased. It does not fire when the height is increased. It does fire for both increasing and decreasing of the panel width though.