Terminal Scrolls search even if find result is visible #78281
Description
Issue Type: Bug
If you are moving through search results via enter or shift+enter the terminal will scroll the terminal even if the search result is in view resulting in some jitter. See https://user-images.githubusercontent.com/4544166/62226436-15344680-b36f-11e9-84cf-ce448c9c9c45.gif
Upstream: xtermjs/xterm.js#2352
VS Code version: Code - Insiders 1.37.0-insider (d5900c6, 2019-07-31T05:21:45.449Z)
OS version: Darwin x64 18.7.0
System Info
| Item | Value |
|---|---|
| CPUs | Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2600) |
| GPU Status | 2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: enabled skia_deferred_display_list: disabled_off skia_renderer: disabled_off surface_synchronization: enabled_on video_decode: enabled viz_display_compositor: disabled_off webgl: enabled webgl2: enabled |
| Load (avg) | 2, 2, 2 |
| Memory (System) | 32.00GB (2.02GB free) |
| Process Argv | |
| Screen Reader | no |
| VM | 18% |
Metadata
Metadata
Assignees
Labels
Issue identified by VS Code Team member as probable bugIssues identified as good for first-time contributorsIssues identified as good community contribution opportunitiesGeneral terminal issues that don't fall under another labelIssue identified as 'upstream' component related (exists outside of VS Code)Verification succeeded