@rebornix I saw that you fixed it in #50189. I am sorry I did not inform you that I was also looking into this. Actually, I have introduced history in Search & Find in the beginning, so I thought I will finish it by fixing this :).

Anyway, I implemented in generic way here. History navigation was implemented outside the inputBox. So every time we need this feature I am duplicating it. For example, similar code is there at following places

Search input
Search replace
Search pattern inputs
Find input
Find replace
Problems filter
Terminal find

I now have a HistoryInputBox widget which has history navigation. Only thing that has to be done from outside to call APIs add/show. I pushed my changes by overriding your implementation.

Let me also tell you another cool change I am doing here. At present, we have two commands (previous/next) per each input box for navigating history. Since history navigation is encapsulated in the widget, I can now have only two commands for all above input boxes. It is similar to the List widget with commands. So basically, I will remove all commands and replace them with following two commands

input.action.historyNext, input.action.historyPrevious.

This is a breaking change but worth to have.

Show Replace history for Editor find widget #50583

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions