-
Notifications
You must be signed in to change notification settings - Fork 34.5k
Description
- VSCode Version: 1.27.2
- OS Version: macOS 10.14 Mojave
Steps to Reproduce:
- Have a Retina screen and macOS 10.14 Mojave installed.
- Open any file.
- Notice the thinner rendering of fonts.
I know there's already #51132 but manually changing a system-wide property affecting all applications to a legacy setting (and sub-pixel smoothing is a legacy setting in Mojave) shouldn't be marked as "fixing" this issue.
I think it's important to stay in line with how the target OS is functioning. Here's how Xcode renders fonts:
Here's iTerm:
Here's VS Code:
And here's an animated version, for easy comparison:
So even on Retina screens, the fonts are very thin and hard to read.
I realize this is related to Electron, as it affects Atom as well – atom/atom#17486. I don't see anyone raising this issue but I think it's very important. Setting CGFontRenderingFontSmoothingDisabled
to NO
is reverting the entire OS back to the legacy setting. Not cool. Let's do it the right way. I'd be happy to open an upstream issue and follow through with this if you can point me in the right direction.
(ping @bpasero)