Skip to content

Proper fix for font smoothing in Mojave #59887

@vl4dimir

Description

@vl4dimir
  • VSCode Version: 1.27.2
  • OS Version: macOS 10.14 Mojave

Steps to Reproduce:

  1. Have a Retina screen and macOS 10.14 Mojave installed.
  2. Open any file.
  3. Notice the thinner rendering of fonts.

I know there's already #51132 but manually changing a system-wide property affecting all applications to a legacy setting (and sub-pixel smoothing is a legacy setting in Mojave) shouldn't be marked as "fixing" this issue.

I think it's important to stay in line with how the target OS is functioning. Here's how Xcode renders fonts:

rendering xcode

Here's iTerm:

rendering iterm

Here's VS Code:

rendering vscode

And here's an animated version, for easy comparison:

rendering animated

So even on Retina screens, the fonts are very thin and hard to read. ☹️

I realize this is related to Electron, as it affects Atom as well – atom/atom#17486. I don't see anyone raising this issue but I think it's very important. Setting CGFontRenderingFontSmoothingDisabled to NO is reverting the entire OS back to the legacy setting. Not cool. Let's do it the right way. I'd be happy to open an upstream issue and follow through with this if you can point me in the right direction.

(ping @bpasero)

Metadata

Metadata

Assignees

Labels

electronIssues and items related to Electronfont-renderingFont rendering issuesimportantIssue identified as high-prioritymojaveVS Code on OS X Mojave issuesupstreamIssue identified as 'upstream' component related (exists outside of VS Code)

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions