Add sidebarFocus, panelFocus, a real editorFocus and focus for each view #59858
Description
Related: #44796 (comment)
I opened #59270 to add 4 commands:
workbench.action.previousPanelViewworkbench.action.previousSidebarViewworkbench.action.nextPanelViewworkbench.action.nextSidebarView
The way I want it to work:
Ctrl-[:
workbench.action.previousPanelViewwhenpanelFocusworkbench.action.previousSidebarViewwhensidebarFocusworkbench.action.previousEditorwheneditorFocus
Ctrl-]:
workbench.action.nextPanelViewwhenpanelFocusworkbench.action.nextSidebarViewwhensidebarFocusworkbench.action.nextEditorwheneditorFocus
They are impossible because of many keybinding issues:
- We only have
filesExplorerFocusfor sidebar views. It's not evenexplorerFocus, meaning that focusing onOpen EditorsorOutlinesdoesn't work - We only have
terminalFocusfor panel views. editorFocusapplies to the input box in search view, input in debug console, etc. There is no context key foreditorFocusactiveViewletandactivePaneldo not help. For example, if I have both sidebar and panel open,activeViewletalways wins in the following setting, even if I'm focused on terminal.
[
{
"key": "cmd+]",
"command": "workbench.action.nextEditor"
},
{
"key": "cmd+[",
"command": "workbench.action.previousEditor"
},
{ "key": "cmd+]", "command": "workbench.action.nextSidebarView", "when": "activeViewlet == workbench.view.explorer" },
{ "key": "cmd+]", "command": "workbench.action.nextSidebarView", "when": "activeViewlet == workbench.view.search" },
{ "key": "cmd+]", "command": "workbench.action.nextSidebarView", "when": "activeViewlet == workbench.view.scm" },
{ "key": "cmd+]", "command": "workbench.action.nextSidebarView", "when": "activeViewlet == workbench.view.debug" },
{ "key": "cmd+]", "command": "workbench.action.nextSidebarView", "when": "activeViewlet == workbench.view.extensions" },
{ "key": "cmd+[", "command": "workbench.action.previousSidebarView", "when": "activeViewlet == workbench.view.explorer" },
{ "key": "cmd+[", "command": "workbench.action.previousSidebarView", "when": "activeViewlet == workbench.view.search" },
{ "key": "cmd+[", "command": "workbench.action.previousSidebarView", "when": "activeViewlet == workbench.view.scm" },
{ "key": "cmd+[", "command": "workbench.action.previousSidebarView", "when": "activeViewlet == workbench.view.debug" },
{ "key": "cmd+[", "command": "workbench.action.previousSidebarView", "when": "activeViewlet == workbench.view.extensions" },
{ "key": "cmd+]", "command": "workbench.action.nextPanelView", "when": "activePanel == workbench.panel.markers" },
{ "key": "cmd+]", "command": "workbench.action.nextPanelView", "when": "activePanel == workbench.panel.output" },
{ "key": "cmd+]", "command": "workbench.action.nextPanelView", "when": "activePanel == workbench.panel.repl" },
{ "key": "cmd+]", "command": "workbench.action.nextPanelView", "when": "activePanel == workbench.panel.terminal" },
{ "key": "cmd+]", "command": "workbench.action.nextPanelView", "when": "activePanel == workbench.panel.comments" },
{ "key": "cmd+]", "command": "workbench.action.nextPanelView", "when": "activePanel == workbench.view.search" },
{ "key": "cmd+[", "command": "workbench.action.previousPanelView", "when": "activePanel == workbench.panel.markers" },
{ "key": "cmd+[", "command": "workbench.action.previousPanelView", "when": "activePanel == workbench.panel.output" },
{ "key": "cmd+[", "command": "workbench.action.previousPanelView", "when": "activePanel == workbench.panel.repl" },
{ "key": "cmd+[", "command": "workbench.action.previousPanelView", "when": "activePanel == workbench.panel.terminal" },
{ "key": "cmd+[", "command": "workbench.action.previousPanelView", "when": "activePanel == workbench.panel.comments" },
{ "key": "cmd+[", "command": "workbench.action.previousPanelView", "when": "activePanel == workbench.view.search" }
]