Skip to content

Debt - remove WinJS.Promise#cancel usage #56137

@jrieken

Description

@jrieken

There are still a few WinJS.Promise#cancel usages and we should remove those. Find detail about how and why here #53526.

Todos for WinJS.Promise#cancel

Todos for WinJS.Promise creation with a non-empty cancel-callback

  • src/vs/base/node/request.ts#67 -> CancellationToken for request logic #57955
  • src/vs/base/common/async.ts#63
  • src/vs/base/common/async.ts#191
  • src/vs/base/common/async.ts#361
  • src/vs/base/test/common/async.test.ts#94
  • src/vs/base/test/common/async.test.ts#116
  • src/vs/base/test/common/utils.ts#21 @jrieken
  • src/vs/editor/standalone/browser/colorizer.ts#58 @alexandrudima
  • src/vs/workbench/api/node/extHostSearch.fileIndex.ts#436 @roblourens
  • src/vs/workbench/api/node/extHostSearch.fileIndex.ts#482
  • src/vs/workbench/api/node/extHostSearch.fileIndex.ts#483
  • src/vs/workbench/api/node/extHostSearch.fileIndex.ts#506
  • src/vs/workbench/api/node/extHostSearch.fileIndex.ts#551
  • src/vs/workbench/api/node/extHostSearch.fileIndex.ts#632
  • src/vs/workbench/api/node/extHostSearch.fileIndex.ts#667
  • src/vs/workbench/api/node/extHostSearch.fileIndex.ts#694
  • src/vs/workbench/api/node/extHostSearch.ts#86 -> Use CancellationToken for search #57957
  • src/vs/workbench/api/node/extHostSearch.ts#311 -> Use CancellationToken for search #57957
  • src/vs/platform/request/electron-browser/requestService.ts#25 -> CancellationToken for request logic #57955
  • src/vs/base/parts/tree/browser/treeModel.ts#89 @joaomoreno
  • src/vs/base/parts/ipc/node/ipc.ts#313
  • src/vs/workbench/services/extensions/node/lazyPromise.ts#40

Metadata

Metadata

Assignees

Labels

debtCode quality issuesengineeringVS Code - Build / issue tracking / etc.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions