Skip to content

Adopt FileSystemProvider for Git #55110

@eamodio

Description

@eamodio

I'm trying to fix gitkraken/vscode-gitlens#430 and I think my best option it to stop creating temp files and instead leverage the built-in git content provider (git: scheme). I have this solution pretty much working (though will require a bunch of burn in), but the biggest issue I'm having is when I'm showing a diff of a file that has been renamed or moved the open file command will fail because the path of the file doesn't match the working tree.

To fix this can we add an optional workingPath to GitUriParams and use it if it exists when executing the open file command?

The other challenge is that using the git content provider doesn't handle images, but I can probably just replicate the logic here:

https://github.com/Microsoft/vscode/blob/master/extensions/git/src/commands.ts#L255-L272

/cc @joaomoreno

Metadata

Metadata

Assignees

Labels

feature-requestRequest for new features or functionalitygitGIT issueson-release-notesIssue/pull request mentioned in release noteson-testplan

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions