Skip to content

Support DAP's terminate request when ending a debug session #54384

@weinand

Description

@weinand

To fix issue microsoft/vscode-node-debug#1 we will add this feature to VS Code:

  • if a debug adapter supports "terminate", VS Code's red terminate button will first send a "terminate" request to the DA (which some DAs might implement by sending a SIGINT signal to the debuggee). VS Code remembers in its debug session state that a "terminate" request has been issued.
  • If the debuggee has no SIGINT handler, the debuggee will terminate and end the debug session. This is almost identical to the current behaviour.
  • if the debuggee has a SIGINT handler but doesn't terminate properly, the debug session will continue. Pressing the red terminate button again will send a "disconnect" request. This will kill the debuggee forcefully (like the current behaviour).

@isidorn I've added a terminate to VA Code's DAP.

Metadata

Metadata

Assignees

Labels

debugDebug viewlet, configurations, breakpoints, adapter issuesfeature-requestRequest for new features or functionalityon-testplanrelease-notesRelease notes issues

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions