I'm posting my thoughts about this, since I've tackled this issue with my Terminals extension.

this issue is about restoring the terminal process shell, args, env and layout

Restoring shell, args and env: I might be wrong on this but I think one can't even set these variables on a per-terminal basis when creating terminals manually, so we would be either restoring terminals with default shell, args and env (nothing to restore basically), or terminals created by extensions, which are going to get recreated by those extensions anyway (there's no way of getting a list of opened terminals, so those extensions can't re-use restored terminals even if they wanted to).

Restoring layout: this is certainly useful, but I personally don't like if throwaway/temporary terminals get restored. And there's no way of knowing which terminal is important and which isn't without providing some kind of configuration.

it would be good to have some basic restoring if it won't get in the way, we certainly wouldn't want to add the complexity that this extension allows.

IMHO the real value comes from restoring commands as well as the layout, and possibly outputs too. Given the relatively low value of a restored layout without commands/output and the problem with duplicated terminals that get recreated by extensions I think it's not worth implementing this into the core.

I need to do some thinking about it, how it interacts with tasks and debug

I personally don't use tasks at all, and I'm not sure how terminals have anything to do with debug, what do you mean exactly?

While we're at it, these are a few API suggestions that would allow me to provide a more powerful/complete extension:

Output restoration: It would be cool if we could restore the output of the terminals, for doing so I think a couple of APIs for reading and replacing a terminal's content are necessary.
Splits restoration: As mentioned here an API for splitting terminals would be necessary in order to add this functionality.
Listing all the terminals: Providing an array of all the opened terminals could be useful.

Restore terminal sessions between restarts #44302

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions