-
Notifications
You must be signed in to change notification settings - Fork 34.9k
Closed
Labels
*duplicateIssue identified as a duplicate of another issue(s)Issue identified as a duplicate of another issue(s)help wantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunitiesterminalGeneral terminal issues that don't fall under another labelGeneral terminal issues that don't fall under another label
Milestone
Description
Basic find in terminal functionality was added in #15198. Here are some of the improvements we can make
-
Highlight all instances of term in current viewportMoved to Terminal Find: Highlight all instances of term in current viewport and don't manipulate selection #134790 -
Use a different selection type so that regular selection isn't hijacked, plus a color with a higher contrast can be used.Moved to Terminal Find: Highlight all instances of term in current viewport and don't manipulate selection #134790 - Find multiple instances on the same line
- Find terms that are wrapped across 2 lines
- Options: regex, case sensitivity, match word
-
Add "No results" label, need to think about what to show in the gap when there are results. We probably shouldn't be searching the entire buffer when we don't have to for performance reasons.Moved to Terminal Find: Show result count #134791 - Add animation to terminal find widget just like it does on editor
Upstream improve find API issue: xtermjs/xterm.js#705
/cc @rebornix
jens1o, carstenfjelkstrup, iignatov, AndrewRayCode, psifertex and 20 morevladimir-incountry and papadi
Metadata
Metadata
Assignees
Labels
*duplicateIssue identified as a duplicate of another issue(s)Issue identified as a duplicate of another issue(s)help wantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunitiesterminalGeneral terminal issues that don't fall under another labelGeneral terminal issues that don't fall under another label