-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Closed
Labels
Description
Problem CSS:
vscode/src/vs/editor/contrib/codelens/browser/codelensWidget.css
Lines 56 to 65 in 8cfe3ee
@keyframes fadein { | |
0% { | |
opacity: 0; | |
visibility: visible; | |
} | |
100% { | |
opacity: 1; | |
} | |
} |
I think we can just remove that visibility
line as that can't be animated. Maybe moving the visibility rule inside the .monaco-editor .codelens-decoration.fadein
below if things don't behave still.
I also noticed that we have 3 different fadein keyframes, some with different casing:
vscode/src/vs/editor/contrib/codelens/browser/codelensWidget.css
Lines 56 to 65 in 8cfe3ee
@keyframes fadein { | |
0% { | |
opacity: 0; | |
visibility: visible; | |
} | |
100% { | |
opacity: 1; | |
} | |
} |
vscode/src/vs/editor/contrib/message/browser/messageController.css
Lines 17 to 20 in 8cfe3ee
@keyframes fadeIn { | |
from { opacity: 0; } | |
to { opacity: 1; } | |
} |
@keyframes fadeIn { from { opacity: 0; } to { opacity: 1; } } |
Should we consolidate these somewhere?