Skip to content

codelensWidget.css animates visibility in fadein animation #250746

@Tyriar

Description

@Tyriar

Image

Image

Problem CSS:

@keyframes fadein {
0% {
opacity: 0;
visibility: visible;
}
100% {
opacity: 1;
}
}

I think we can just remove that visibility line as that can't be animated. Maybe moving the visibility rule inside the .monaco-editor .codelens-decoration.fadein below if things don't behave still.

I also noticed that we have 3 different fadein keyframes, some with different casing:

@keyframes fadein {
0% {
opacity: 0;
visibility: visible;
}
100% {
opacity: 1;
}
}

@keyframes fadeIn {
from { opacity: 0; }
to { opacity: 1; }
}

@keyframes fadeIn { from { opacity: 0; } to { opacity: 1; } }

Should we consolidate these somewhere?

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions