Skip to content

ITextModel.onDidChangeContent cannot be used with observableFromEvent #242059

New issue
New issue
Closed
#250833
Closed
ITextModel.onDidChangeContent cannot be used with observableFromEvent#242059
#250833
Assignees
hediet
Labels
debtCode quality issuesinsiders-releasedPatch has been released in VS Code Insiders
Milestone
June 2025
@jrieken

Description

@jrieken
jrieken
opened on Feb 26, 2025

See

vscode/src/vs/workbench/contrib/inlineChat/browser/inlineChatCurrentLine.ts

Lines 243 to 247 in 77dee8c

// DEBT - I cannot use `model.onDidChangeContent` directly here
// https://github.com/microsoft/vscode/issues/242059
const emitter = store.add(new Emitter<void>());
store.add(model.onDidChangeContent(() => emitter.fire()));
observableFromEvent(emitter.event, () => model.getVersionId()).read(r);

I had to do the weird workaround with the extra emitter because the onDidChangeContent event seems to be special

Metadata

Metadata

Assignees

Labels

debtCode quality issuesinsiders-releasedPatch has been released in VS Code Insiders

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions