Hey @isidorn, I have this code to update some notebook metadata based on the current debug state, but it slows things down by generating too many callstack requests, and I don't know how to do this the right way

vscode/src/vs/workbench/contrib/notebook/browser/contrib/breakpoints/notebookBreakpoints.ts

Line 115 in 0a3b4bd

private async onDidChangeCallStack(): Promise<void> {

I think one problem is that we might call fetchCallStack when a request has already been sent by CallStackView. If a request is already in flight, I want to wait on that request instead of triggering a new one.

And I have to call fetch, because otherwise the callstack is empty when the onDidChangeCallStack is fired. If I don't call fetch, then I get the event 3 times for each step with an empty callstack. But I think this generates a lot of load. I guess it is faster in the callstack because it debounces updates and requests just one frame first?

(There are 4 threads)

So it's not clear to me how to do this efficiently.

Step over and Step in are quite slow #127720

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions