Skip to content

Iframe webview: search can crash the process #126729

@bpasero

Description

@bpasero

Extracted from #125856 (for #96307)

I can reproduce 2 scenarios where a crash occurs:

Crash when document changes

  • open preview
  • open file as well
  • start search in preview
  • change file by e.g. adding a word that is searched
  • 💥 crash

0045564b-de8d-4298-972c-37c9c6e6650a.dmp.zip

Crash when reopening preview

  • open a preview
  • open find and start typing
  • quickly close the preview
  • open preview again
  • 💥 crash

03b9b157-63f0-4749-b3e4-699582f41fad.dmp.zip

I am not sure if both crashes are the same.

For the second crash, I wonder if we are missing to call stopFind once the editor closes (we do not even call this when webiew is enabled I think).

Metadata

Metadata

Labels

electronIssues and items related to Electronfreeze-slow-crash-leakVS Code crashing, performance, freeze and memory leak issuesinsiders-releasedPatch has been released in VS Code InsiderssandboxRunning VSCode in a node-free environmentverifiedVerification succeededwebviewWebview issues

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions