Skip to content

Build: Darwin arm64 rebuild binaries should be in cache #112319

New issue
New issue
Closed
Closed
Build: Darwin arm64 rebuild binaries should be in cache#112319
Assignees
deepak1556
Labels
engineeringVS Code - Build / issue tracking / etc.
Milestone
Backlog
@joaomoreno

Description

@joaomoreno
joaomoreno
opened on Dec 11, 2020

vscode/build/azure-pipelines/darwin/product-build-darwin.yml

Lines 120 to 131 in d819caf

- script: |
set -e
export npm_config_arch=$(VSCODE_ARCH)
export npm_config_node_gyp=$(which node-gyp)
export npm_config_build_from_source=true
export SDKROOT=/Applications/Xcode_12.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk
ls /Applications/Xcode_12.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/
yarn electron-rebuild
cd ./node_modules/keytar
node-gyp rebuild
displayName: Rebuild native modules for ARM64
condition: eq(variables['VSCODE_ARCH'], 'arm64')

@deepak1556 Shouldn't these be in the node_modules build cache as well?

Also, since we're looking into reducing build time... it seems like we first build them... and then we rebuild them. Any chance we can build them right the first time?

Metadata

Metadata

Assignees

Labels

engineeringVS Code - Build / issue tracking / etc.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions