-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Closed
Labels
ghcs-adoption-neededgithub-codespacesios-ipadoslayoutGeneral VS Code workbench layout issuesGeneral VS Code workbench layout issueswebIssues related to running VSCode in the webIssues related to running VSCode in the web
Milestone
Description
Only reproducible on Codespace on iPadOS.
Steps to Reproduce:
- Open Codespace on iPadOS 14.
- Type in either the editor or terminal, the keyboard help toolbar shows up
- Click the keyboard icon on the toolbar (rightmost) to hide the toolbar
- The workbench should resize itself when the toolbar shows or hides
We listen to resize
event on window.visualViewport
vscode/src/vs/workbench/browser/web.main.ts
Line 113 in b0dc858
this._register(addDisposableListener(viewport, EventType.RESIZE, () => workbench.layout())); |
- when testing OSS, I can never reproduce
- when testing codespace, I can reproduce more than 50% of the time
- In Safari Devtools, if I add a
resize
listener towindow.visualViewport
and print the viewport size when it changes, it always emits the event when the viewport resizes. It might mean that Safari is emitting events out correctly. - In Safari Devtools, whenever I open the bundled js or try to inspect the workbench Dom element, devtools crash so I can't debug at all
@bpasero do you have ideas about how we can add some log (maybe emit to outputs channel, behind a flag) and then we can continue our investigation which part might misbehave?
Does this issue occur when all extensions are disabled?: Yes/No
Metadata
Metadata
Assignees
Labels
ghcs-adoption-neededgithub-codespacesios-ipadoslayoutGeneral VS Code workbench layout issuesGeneral VS Code workbench layout issueswebIssues related to running VSCode in the webIssues related to running VSCode in the web