-
Notifications
You must be signed in to change notification settings - Fork 34.9k
Closed
Labels
debtCode quality issuesCode quality issuesinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsidersterminalGeneral terminal issues that don't fall under another labelGeneral terminal issues that don't fall under another labelwindowsVS Code on Windows issuesVS Code on Windows issues
Milestone
Description
Currently WindowsShellHelper
runs on the renderer process and it is used to classify the current shell on Windows which drives the terminalShellType
context key for keybindings as well as the terminal name that shows up in the dropdown. This has always been a debt item that it should be running on the extension host for the remote use case but has never been high priority since it's a small feature that it supports and Windows SSH is fairly new is not a big share of our remote-ssh usage.
This would ideally move to where ever ends up hosting node-pty after the item in #92164 is done.
Metadata
Metadata
Assignees
Labels
debtCode quality issuesCode quality issuesinsiders-releasedPatch has been released in VS Code InsidersPatch has been released in VS Code InsidersterminalGeneral terminal issues that don't fall under another labelGeneral terminal issues that don't fall under another labelwindowsVS Code on Windows issuesVS Code on Windows issues