Skip to content

ITerminalInstance.onData should be higher level #18453

@dbaeumer

Description

@dbaeumer
  • VSCode Version: 1.9.x

The callback trigger on ITerminalInstance.onData() receives a string containing the raw pty output including the ANSI Control characters. Although this might be useful for some clients I think the majority is not interested in ANSI Control characters since the interpretation is not easy. I therefore suggest that the terminal provide two different listeners. One raw listener that includes the data like it is today and one line based listener that fires if

  1. a line got added to the output
  2. when a line got changed.

The event should contain the line number as well.

Metadata

Metadata

Assignees

Labels

terminalGeneral terminal issues that don't fall under another label

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions