Skip to content

Make accessibility help generic #183363

@Tyriar

Description

@Tyriar

Currently we have a few different accessibility help dialogs that appear, for example:

Editor:

The editor help is a popup with a header and div

Terminal:

The terminal has a monaco editor appear inline inside the terminal

Chat view:

The chat view reuses the prompt monaco editor

They each work similar but have different implementations and different commands (they probably share some code, I'm not sure).

My proposal is to have a single command "Show Accessibility Help" bound to alt+f1 across the whole workbench, components can register their own custom text which ends up showing in a centered monaco editor. From there we can trap the focus on the editor and escape or clicking out of the dialog would hide it and return focus to the previous activeElement.

The presentation of it could look similar to the editor dialog but have a monaco editor inside instead. It could also have a 50% black background to give a strong indication that you can click here to get out. The actual visual presentation isn't too important but with a single implementation we can make it look good just one time.

This would lead to a consistent experience across all components that use it, shared implementation, a single lazy loaded monaco editor that's only constructed when needed and it wouldn't lead to potential issues such as getting the content and the help message mixed up when it's currently sharing an editor.

cc @jooyoungseo

Metadata

Metadata

Assignees

Labels

accessibilityKeyboard, mouse, ARIA, vision, screen readers (non-specific) issuesfeature-requestRequest for new features or functionalityon-release-notesIssue/pull request mentioned in release noteson-testplan

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions