Skip to content

Investigate moving away from the styler pattern #165478

@alexdima

Description

@alexdima

Having more styling be done via CSS would reduce the amount of JS code we need to ship and run. We should investigate if it is possible to achieve the same composition as we do today in JS, by using CSS variables. We should also check that this doesn't cause any performance problems and that it is idiomatic CSS

/* in base widget CSS */
.monaco-inputbox {
    --monaco-inputbox-foreground: #CCCCCC;
}
.monaco-inputbox {
    position: relative;
    display: block;
    padding: 0;
    box-sizing: border-box;
    border-radius: 2px;
    /* Customizable */
    font-size: inherit;
    color: var(--monaco-inputbox-foreground)
}

/* in widget user CSS */
.findWidget .monaco-inputbox {
    --monaco-inputbox-foreground: var(--vscode-find-widget-input);
}

Metadata

Metadata

Assignees

Labels

editor-themingIssues related to the way themes are applied to editorsfeature-requestRequest for new features or functionalityplan-itemVS Code - planned item for upcomingverification-neededVerification of issue is requestedverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions