add commonjs annotation to package.json
#1179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b9d105f to
bc2ad66
Compare
benibenj
approved these changes
Jul 3, 2025
aeschli
approved these changes
Jul 3, 2025
|
@benibenj, do you know what the stalled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on making this tool compatible with
denoandbunfor a personal project. It looks like I'm not the only one who would like to add that support (See: #1108)Modern JS standards suggest either using a
.cjsextension or a moduletypedeclaration on a package to know whether something is a commonjs module or an esm module. See: https://nodejs.org/api/packages.html#packagejson-and-file-extensionsThis change adds the missing
"type": "commonjs"annotation to the package.json file to allowdenoto run the files correctly.