Skip to content

Remove DI from debug configuration providers #19785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 15, 2022
Merged

Remove DI from debug configuration providers #19785

merged 9 commits into from
Sep 15, 2022

Conversation

paulacamargo25
Copy link

Closed: #19766

@paulacamargo25 paulacamargo25 self-assigned this Sep 6, 2022
@paulacamargo25 paulacamargo25 added area-debugging feature-request Request for new features or functionality labels Sep 6, 2022
karthiknadig
karthiknadig reviewed Sep 6, 2022
View reviewed changes
Copy link
Member

@karthiknadig karthiknadig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use fs-extra instead of fs

@paulacamargo25 paulacamargo25 force-pushed the 19766-Remove-DP-from-providers branch from b556035 to 6f06fb4 Compare September 9, 2022 18:15
karthiknadig
karthiknadig requested changes Sep 12, 2022
View reviewed changes
@paulacamargo25 paulacamargo25 force-pushed the 19766-Remove-DP-from-providers branch from e3c06ee to fd12c2b Compare September 12, 2022 18:04
@paulacamargo25 paulacamargo25 force-pushed the 19766-Remove-DP-from-providers branch from 7c40252 to 8151018 Compare September 15, 2022 00:22
@paulacamargo25 paulacamargo25 merged commit ad74f51 into microsoft:main Sep 15, 2022
eleanorjboyd pushed a commit to eleanorjboyd/vscode-python that referenced this pull request Oct 4, 2022
@paulacamargo25 @eleanorjboyd
Remove DI from debug configuration providers (microsoft#19785)
66cbd91 
Closed: microsoft#19766
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
@paulacamargo25 @wesm
Remove DI from debug configuration providers (microsoft/vscode-python…
3f8f2f1 
…#19785)

Closed: microsoft/vscode-python#19766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

Assignees

@paulacamargo25 paulacamargo25

Labels
area-debugging feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove DI from debug configuration providers
2 participants
@paulacamargo25 @karthiknadig