Skip to content

Fix interactive window placeholder cell updates #7340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2021
Merged

Fix interactive window placeholder cell updates #7340

merged 1 commit into from
Aug 30, 2021

Conversation

joyceerhl
Copy link
Contributor

@joyceerhl joyceerhl commented Aug 30, 2021 •
edited
Loading

@rchiodo found that when restarting a kernel, existing sys info cells get overwritten instead of a new sys info cell with the restart message being appended. The cause appears to be that existing metadata properties aren't being zeroed on the VS Code side (which I assumed that an API with replace in the name would do)

This is a candidate for the August release.

@joyceerhl joyceerhl requested a review from a team as a code owner August 30, 2021 17:40
@codecov-commenter
Copy link

Codecov Report

Merging #7340 (f214159) into main (69ae8c3) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##            main   #7340   +/-   ##
=====================================
  Coverage     65%     65%           
=====================================
  Files        360     360           
  Lines      22553   22551    -2     
  Branches    3413    3411    -2     
=====================================
- Hits       14788   14787    -1     
+ Misses      6465    6461    -4     
- Partials    1300    1303    +3
Impacted Files Coverage Δ
src/client/datascience/jupyter/kernels/kernel.ts 74% <100%> (+<1%) ⬆️
src/client/common/cancellation.ts 72% <0%> (-4%) ⬇️
...ence/interactive-window/nativeInteractiveWindow.ts 24% <0%> (-3%) ⬇️
.../datascience/notebook/notebookControllerManager.ts 87% <0%> (-2%) ⬇️
src/client/common/utils/decorators.ts 78% <0%> (-2%) ⬇️
src/client/datascience/jupyter/kernelVariables.ts 44% <0%> (-1%) ⬇️
src/client/datascience/baseJupyterSession.ts 62% <0%> (-1%) ⬇️
src/client/datascience/jupyter/jupyterNotebook.ts 52% <0%> (+1%) ⬆️
src/client/common/utils/async.ts 43% <0%> (+2%) ⬆️
...lient/datascience/variablesView/notebookWatcher.ts 83% <0%> (+2%) ⬆️
... and 2 more

@joyceerhl joyceerhl merged commit 6165d06 into main Aug 30, 2021
@joyceerhl joyceerhl deleted the dev/joyceerhl/iw-placeholder-cell branch August 30, 2021 18:04
@joyceerhl joyceerhl mentioned this pull request Aug 30, 2021
Closed
joyceerhl added a commit that referenced this pull request Aug 30, 2021
@joyceerhl
Fix interactive window placeholder cell updates (#7340)
74c1106
joyceerhl added a commit that referenced this pull request Aug 30, 2021
@joyceerhl
Fix interactive window placeholder cell updates (#7340) (#7343)
8bdf492
joyceerhl added a commit that referenced this pull request Aug 31, 2021
@joyceerhl
Revert "Fix interactive window placeholder cell updates (#7340) (#7343)"
eb4988a 
This reverts commit 8bdf492.
joyceerhl added a commit that referenced this pull request Aug 31, 2021
@joyceerhl
Revert sys info changes in release branch (#7362)
d80e277 
* Revert "Fix interactive window placeholder cell updates (#7340) (#7343)"

This reverts commit 8bdf492.

* Revert "Fix placeholder sys info cell not being updated correctly (#7307)"

This reverts commit 64ba681.

* Update changelog

* Tweak interactive window test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchiodo rchiodo rchiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joyceerhl @codecov-commenter @rchiodo