Fix placeholder sys info cell not being updated correctly in interactive window #7307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #7307 +/- ##
======================================
+ Coverage 62% 64% +2%
======================================
Files 360 360
Lines 22535 22536 +1
Branches 3402 3403 +1
======================================
+ Hits 14077 14625 +548
+ Misses 7282 6609 -673
- Partials 1176 1302 +126
|
IanMatthewHuff
approved these changes
Aug 26, 2021
joyceerhl
added a commit
that referenced
this pull request
Aug 31, 2021
)" This reverts commit 64ba681.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7280
Root cause is code assumed the placeholder cell was the last one in the notebook document and didn't check any of the other cells, so if you added a cell via the input box while the kernel was starting, it would update the wrong cell. We are still assuming there's only one placeholder cell in the entire interactive window.
We could also just check the first cell, but that seems equally brittle e.g. if on a kernel restart we decide to show the placeholder cell as well, that won't work correctly.