Skip to content

Fix restart/interrupt kernel for interactive window script file #7241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 24, 2021
Merged

Fix restart/interrupt kernel for interactive window script file #7241

merged 2 commits into from
Aug 24, 2021

Conversation

joyceerhl
Copy link
Contributor

Fix #7158

@joyceerhl joyceerhl requested a review from a team as a code owner August 23, 2021 23:00
IanMatthewHuff
IanMatthewHuff reviewed Aug 23, 2021
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2021 •
edited
Loading

Codecov Report

Merging #7241 (221ea9e) into main (b1475c7) will increase coverage by 0%.
The diff coverage is n/a.

❗ Current head 221ea9e differs from pull request most recent head 0d2d9fb. Consider uploading reports for the commit 0d2d9fb to get more accurate results

@@          Coverage Diff          @@
##            main   #7241   +/-   ##
=====================================
  Coverage     62%     62%           
=====================================
  Files        360     360           
  Lines      22541   22541           
  Branches    3400    3400           
=====================================
+ Hits       14064   14065    +1     
+ Misses      7303    7302    -1     
  Partials    1174    1174
Impacted Files Coverage Δ
...tascience/jupyter/kernels/kernelCommandListener.ts 55% <ø> (ø)
...lient/datascience/variablesView/notebookWatcher.ts 62% <ø> (ø)
...ient/datascience/kernel-launcher/kernelLauncher.ts 91% <0%> (+1%) ⬆️

IanMatthewHuff
IanMatthewHuff requested changes Aug 23, 2021
View reviewed changes
Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When condition might be off? Looking at the code I'm not even sure if that havenativeredoablecells is hooked up.

@IanMatthewHuff
Copy link
Member

@joyceerhl BTW, I see that you had a Prettier failure. For some reason in my PR Prettier had failed to run for me locally, I had to restart VS Code before Prettier worked. Not sure why...

@joyceerhl joyceerhl merged commit b3d58bf into main Aug 24, 2021
@joyceerhl joyceerhl deleted the dev/joyceerhl/contexts branch August 24, 2021 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Command palette interrupt/restart not there for a python file
3 participants
@joyceerhl @codecov-commenter @IanMatthewHuff