Log debug adapter traffic #7219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #7219 +/- ##
=====================================
- Coverage 64% 64% -1%
=====================================
Files 360 360
Lines 22564 22541 -23
Branches 3401 3395 -6
=====================================
- Hits 14637 14619 -18
+ Misses 6628 6625 -3
+ Partials 1299 1297 -2
|
Add a "verbose" logging level Fix #6468
18f811a to
12b9eda
Compare
DavidKutu
approved these changes
Aug 21, 2021
| @@ -186,7 +186,7 @@ export interface IWatchableJupyterSettings extends IJupyterSettings { | |||
| readonly onDidChange: Event<void>; | |||
| } | |||
|
|
|||
| export type LoggingLevelSettingType = 'off' | 'error' | 'warn' | 'info' | 'debug'; | |||
| export type LoggingLevelSettingType = 'off' | 'error' | 'warn' | 'info' | 'debug' | 'verbose'; | |||
There was a problem hiding this comment.
I personally think we should clean all of this, I don't know if anyone uses them. Feels rather redundant to have warn|info|debug, I think off|error|verbose are sufficient.
There was a problem hiding this comment.
Something for debt week
DonJayamanne
approved these changes
Aug 23, 2021
joyceerhl
pushed a commit
that referenced
this pull request
Aug 23, 2021
Add a "verbose" logging level Fix #6468
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a "verbose" logging level
Fix #6468