Add esc to clear interactive window input editor contents
#7208
Conversation
package.json
Outdated
| @@ -197,6 +197,11 @@ | |||
| "when": "resourceScheme == 'vscode-interactive'", | |||
| "command": "interactive.execute" | |||
| }, | |||
| { | |||
| "key": "escape", | |||
| "when": "resourceScheme == 'vscode-interactive' && !suggestWidgetVisible", | |||
There was a problem hiding this comment.
We also need to include !editorHoverVisible, !exceptionWidgetVisible, !editorHasMultipleSelections, !inlineSuggestionVisible, !isComposing, !inSnippetMode, !parameterHintsVisible, !renameInputVisible. (I went through default keybindings for Escape.)
There was a problem hiding this comment.
Thanks for pointing that out, I went through the default keybindings for escape and came up with this list. IIRC there was a problem with excessively complex when clauses resulting in perf problems, and I'm not sure all of these are strictly required:
resourceScheme == 'vscode-interactive' &&
!editorHoverVisible &&
!suggestWidgetVisible &&
!isComposing &&
!inSnippetMode &&
!exceptionWidgetVisible &&
!selectionAnchorSet &&
!LinkedEditingInputVisible &&
!renameInputVisible &&
!editorHasSelection &&
!accessibilityHelpWidgetVisible &&
!breakpointWidgetVisible &&
!findWidgetVisible &&
!markersNavigationVisible &&
!parameterHintsVisible &&
!editorHasMultipleSelections &&
!notificationToastsVisible
Codecov Report
@@ Coverage Diff @@
## main #7208 +/- ##
=====================================
Coverage 64% 64%
=====================================
Files 359 360 +1
Lines 22656 22564 -92
Branches 3416 3401 -15
=====================================
- Hits 14638 14622 -16
+ Misses 6718 6641 -77
- Partials 1300 1301 +1
|
Fix #7157