Skip to content

dump all cells in the notebook and remove IDebuggingCellMap #7112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2021
Merged

dump all cells in the notebook and remove IDebuggingCellMap #7112

merged 2 commits into from
Aug 13, 2021

Conversation

DavidKutu
Copy link

For #7037
and partially fixes #6856

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@DavidKutu DavidKutu requested a review from a team as a code owner August 12, 2021 23:47
@DavidKutu DavidKutu requested a review from roblourens August 12, 2021 23:47
@codecov-commenter
Copy link

Codecov Report

Merging #7112 (99a55c8) into main (89da385) will decrease coverage by 1%.
The diff coverage is 16%.

@@          Coverage Diff           @@
##            main   #7112    +/-   ##
======================================
- Coverage     65%     63%    -2%     
======================================
  Files        363     362     -1     
  Lines      22914   22885    -29     
  Branches    3435    3435            
======================================
- Hits       14895   14480   -415     
- Misses      6714    7180   +466     
+ Partials    1305    1225    -80
Impacted Files Coverage Δ
src/client/datascience/serviceRegistry.ts 98% <ø> (-1%) ⬇️
src/client/datascience/types.ts 100% <ø> (ø)
src/client/debugger/jupyter/kernelDebugAdapter.ts 6% <0%> (ø)
src/client/debugger/jupyter/debuggingManager.ts 25% <100%> (-3%) ⬇️
...ience/variablesView/variableViewMessageListener.ts 22% <0%> (-78%) ⬇️
...ent/common/application/webviewViews/webviewView.ts 14% <0%> (-72%) ⬇️
...c/client/datascience/variablesView/variableView.ts 17% <0%> (-61%) ⬇️
src/client/datascience/webviews/webviewViewHost.ts 21% <0%> (-58%) ⬇️
src/client/common/application/webviews/webview.ts 13% <0%> (-54%) ⬇️
src/client/datascience/themeFinder.ts 13% <0%> (-48%) ⬇️
... and 21 more

@DavidKutu DavidKutu merged commit c27e2c0 into main Aug 13, 2021
@DavidKutu DavidKutu deleted the david/dumpAllCellsInTheNB branch August 13, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchiodo rchiodo rchiodo approved these changes

@roblourens roblourens Awaiting requested review from roblourens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running line by line in a model learning cell breaks
3 participants
@DavidKutu @codecov-commenter @rchiodo