Clicking the wrong RBL button should be a no-op #7083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88e9742 to
66562c8
Compare
rchiodo
approved these changes
Aug 11, 2021
Codecov Report
@@ Coverage Diff @@
## main #7083 +/- ##
=====================================
- Coverage 65% 65% -1%
=====================================
Files 362 362
Lines 22897 22897
Branches 3426 3428 +2
=====================================
- Hits 14910 14906 -4
- Misses 6683 6685 +2
- Partials 1304 1306 +2
|
DavidKutu
approved these changes
Aug 12, 2021
|
Is it ok that some failed? Seems like random failures |
|
Yes, they're unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6868
And fix #6905
Ideally we would hide the RBL buttons on cells that are not doing RBL, but we really don't have a way to do that with context keys right now, so I just make the ones on other notebooks or cells no-op