Skip to content

Have a per interpreter language server in the jupyter extension #7924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Oct 14, 2021
Merged

Have a per interpreter language server in the jupyter extension #7924

merged 22 commits into from
Oct 14, 2021

Conversation

rchiodo
Copy link
Contributor

@rchiodo rchiodo commented Oct 13, 2021

Fixes #6333

Using the new lsp-middleware npm module, create a language server for notebook cells in the jupyter extension.

I'm going to also put up a PR for python to use the new 'Hiding' middleware for notebook cells so that we don't end up with double.

@rchiodo rchiodo requested a review from a team as a code owner October 13, 2021 23:32
@rchiodo rchiodo mentioned this pull request Oct 13, 2021
Merged
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2021 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.55102% with 55 lines in your changes missing coverage. Please review.

Project coverage is 70%. Comparing base (8f06db9) to head (71a511d).
Report is 2847 commits behind head on main.

Files with missing lines Patch % Lines
...atascience/notebook/intellisense/languageServer.ts 71% 24 Missing and 7 partials ⚠️
...book/intellisense/fileBasedCancellationStrategy.ts 69% 13 Missing ⚠️
...ence/notebook/intellisense/intellisenseProvider.ts 87% 5 Missing and 5 partials ⚠️
src/client/pythonEnvironments/info/interpreter.ts 75% 1 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff           @@
##            main   #7924    +/-   ##
======================================
- Coverage     70%     70%    -1%     
======================================
  Files        361     364     +3     
  Lines      22155   22427   +272     
  Branches    3376    3416    +40     
======================================
+ Hits       15663   15833   +170     
- Misses      5119    5211    +92     
- Partials    1373    1383    +10
Files with missing lines Coverage Δ
src/client/common/constants.ts 96% <100%> (+<1%) ⬆️
src/client/datascience/notebook/integration.ts 100% <100%> (ø)
...notebook/intellisense/jupyterCompletionProvider.ts 60% <100%> (ø)
src/client/datascience/notebook/serviceRegistry.ts 100% <100%> (ø)
src/client/pythonEnvironments/info/interpreter.ts 84% <75%> (-2%) ⬇️
...ence/notebook/intellisense/intellisenseProvider.ts 87% <87%> (ø)
...book/intellisense/fileBasedCancellationStrategy.ts 69% <69%> (ø)
...atascience/notebook/intellisense/languageServer.ts 71% <71%> (ø)

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DonJayamanne
DonJayamanne approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only issue is with caching of the promise, else we end up with multiple language servers, else all good.

@rchiodo rchiodo merged commit ef6ed38 into main Oct 14, 2021
@rchiodo rchiodo deleted the rchiodo/per_interpreter_language_server branch October 14, 2021 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jupyter notebook kernel changes not detected to Pylance
3 participants
@rchiodo @codecov-commenter @DonJayamanne