Skip to content

Conversation

joyceerhl
Copy link
Contributor

Fix #7366

@joyceerhl joyceerhl requested a review from a team as a code owner September 13, 2021 19:59
Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks legit for now, wasn't there some discussion that IKernel restart might go away and we just kill the IKernel and create a new one on restart?

@joyceerhl
Copy link
Contributor Author

Yeah #7463 that might not work so well then.

@IanMatthewHuff
Copy link
Member

Yeah #7463 that might not work so well then.

I think it's fine now as that's the way the code is. Just more of a note that we might need a tweak here later. If we remove the restarted event on the kernel we can just change this then.

@joyceerhl joyceerhl merged commit 8521f8c into main Sep 13, 2021
@joyceerhl joyceerhl deleted the dev/joyceerhl/iw-restart-debug branch September 13, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debugging cells in the interactive window will show the 'temp hashed file' if you restart the kernel
3 participants