Skip to content

Pass placeholder cell to be updated through to addSysInfoForInteractive #7484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2021
Merged

Pass placeholder cell to be updated through to addSysInfoForInteractive #7484

merged 1 commit into from
Sep 13, 2021

Conversation

joyceerhl
Copy link
Contributor

Fix #7280

@joyceerhl joyceerhl requested a review from a team as a code owner September 11, 2021 17:15
@codecov-commenter
Copy link

Codecov Report

Merging #7484 (3711f9f) into main (c0f2a08) will increase coverage by 0%.
The diff coverage is 72%.

@@          Coverage Diff          @@
##            main   #7484   +/-   ##
=====================================
  Coverage     64%     64%           
=====================================
  Files        361     361           
  Lines      22506   22508    +2     
  Branches    3422    3424    +2     
=====================================
+ Hits       14542   14593   +51     
+ Misses      6742    6692   -50     
- Partials    1222    1223    +1
Impacted Files Coverage Δ
src/client/datascience/jupyter/kernels/kernel.ts 70% <72%> (-1%) ⬇️
...tascience/jupyter/kernels/kernelCommandListener.ts 55% <0%> (-3%) ⬇️
...lient/datascience/variablesView/notebookWatcher.ts 67% <0%> (-2%) ⬇️
...lient/datascience/jupyter/kernels/cellExecution.ts 77% <0%> (-1%) ⬇️
src/client/datascience/jupyter/jupyterNotebook.ts 22% <0%> (-1%) ⬇️
src/client/datascience/baseJupyterSession.ts 67% <0%> (+<1%) ⬆️
src/client/datascience/dataScienceSurveyBanner.ts 55% <0%> (+<1%) ⬆️
...client/datascience/kernel-launcher/kernelDaemon.ts 57% <0%> (+1%) ⬆️
src/client/datascience/cellFactory.ts 62% <0%> (+2%) ⬆️
...client/datascience/editor-integration/decorator.ts 76% <0%> (+2%) ⬆️
... and 4 more

@joyceerhl joyceerhl merged commit ba3e176 into main Sep 13, 2021
@joyceerhl joyceerhl deleted the dev/joyceerhl/fix-sys-info branch September 13, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

@rchiodo rchiodo rchiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output order is incorrect
4 participants
@joyceerhl @codecov-commenter @DonJayamanne @rchiodo