Skip to content

Conversation

joyceerhl
Copy link
Contributor

Fix #7476, adopting microsoft/vscode#132879

GIF of combined VS Code and Jupyter extension changes:
recording (23)

@joyceerhl joyceerhl requested a review from a team as a code owner September 10, 2021 18:16
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2021

Codecov Report

Merging #7482 (26c8460) into main (c0f2a08) will decrease coverage by 0%.
The diff coverage is 66%.

@@          Coverage Diff          @@
##            main   #7482   +/-   ##
=====================================
- Coverage     64%     64%   -1%     
=====================================
  Files        361     361           
  Lines      22506   22517   +11     
  Branches    3422    3425    +3     
=====================================
+ Hits       14542   14544    +2     
- Misses      6742    6748    +6     
- Partials    1222    1225    +3     
Impacted Files Coverage Δ
src/client/datascience/types.ts 100% <ø> (ø)
...atascience/interactive-window/interactiveWindow.ts 52% <33%> (-1%) ⬇️
...lient/datascience/variablesView/notebookWatcher.ts 67% <60%> (-1%) ⬇️
src/client/datascience/notebook/helpers/helpers.ts 55% <71%> (+<1%) ⬆️
...science/jupyter/kernels/kernelDependencyService.ts 86% <77%> (-2%) ⬇️
...tascience/jupyter/kernels/kernelCommandListener.ts 55% <0%> (-3%) ⬇️
...lient/datascience/jupyter/kernels/cellExecution.ts 77% <0%> (-1%) ⬇️
src/client/datascience/jupyter/jupyterNotebook.ts 22% <0%> (-1%) ⬇️
src/client/datascience/dataScienceSurveyBanner.ts 55% <0%> (+<1%) ⬆️

@joyceerhl
Copy link
Contributor Author

Peng is out till Wednesday, merging this now because it's harmless to do so even if microsoft/vscode#132879 hasn't been shipped (tested locally for IW and notebooks; the passed NotebookEditor is simply ignored)

@joyceerhl joyceerhl merged commit f089f50 into main Sep 13, 2021
@joyceerhl joyceerhl deleted the dev/joyceerhl/adopt-select-kernel branch September 13, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking 'Change Kernel' for interactive window started from script file does nothing
3 participants